Closed Bug 1340143 Opened 8 years ago Closed 8 years ago

[clang-format] Should put on a new line every classes when more than one is used

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox54 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox54 --- affected

People

(Reporter: Sylvestre, Assigned: andi)

References

Details

With our coding style we should have: class MyClass : public X // When deriving from more than one class, put each on its own line. , public Y and clang-format will give us: class MyClass : public X // When deriving from more than one class, put each on // its own line. , public Y
Assignee: nobody → bpostelnicu
Added patch here for upstream: https://reviews.llvm.org/D30487
The fix landed upstream: https://reviews.llvm.org/rL297467
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.